Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development version has problems with remapping thumb cluster keys #680

Closed
0rzech opened this issue Jan 22, 2024 · 2 comments · Fixed by #688
Closed

Development version has problems with remapping thumb cluster keys #680

0rzech opened this issue Jan 22, 2024 · 2 comments · Fixed by #688
Labels
bug Something isn't working

Comments

@0rzech
Copy link
Contributor

0rzech commented Jan 22, 2024

Describe the bug
Bazecor built from 8364b31 (and possibly earlier) has problems with remapping thumb cluster keys.

To Reproduce
Steps to reproduce the behavior:

  1. Build Bazecor from 8364b31 .
  2. Open Bazecor.
  3. Select some thumb cluster key on keyboard visualisation.
  4. Problem no. 1: If thumb key has something assigned already, on the left of keyboard picker it still says NO.KEY.
  5. Pick some key from keyboard picker.
  6. Problem no. 2: Picked symbol is properly shown on keyboard visualisation, not on the left of keyboard picker, i.e. it remains NO.KEY.
  7. Add some modifier, eg. Alt Gr.
  8. Problem no. 3: Selected key on keyboard visualisation changes to NO KEY.
  9. Problem no. 4: Clicking one-by-one thumb cluster keys on keyboard picker can occasionally dim the whole keyboard picker, though the keys on it remain clickable.

Expected behavior
Remapping thumb cluster keys should work as expected.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Linux
  • Bazecor Version: 1.3.10-rc.3

Additional context
The problem does not happen for alphanumeric keys.

@0rzech 0rzech added the bug Something isn't working label Jan 22, 2024
@alexpargon
Copy link
Contributor

Wow! @0rzech

I wish I had read you before releasing the 1.3.10 stable 🤣

Ill push a hotfix today to solve this.

@alexpargon alexpargon linked a pull request Jan 25, 2024 that will close this issue
@0rzech
Copy link
Contributor Author

0rzech commented Jan 25, 2024

Haha! No problem! 😉 At first I was surprised that you released anyways, but then I came to conclusion that maybe you had some hard deadline or just went YOLO 🤣, or that you release often enough just to fix in next iteration. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants