You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the plugin have no settings defined (no matching page to show his components), it crashed the entire wn-pages-plugin.
Adding some page with matching components resolve the issue.
Maybe the plugin should use fall-back settings when these are not given.
// Actual
Settings::instance()->get('postPage')
// Better ??
Settings::instance()->get('postPage', 'post-page')
The text was updated successfully, but these errors were encountered:
I have tried to replicate this using the default Winter theme with no Posts pages and no configuration of the Posts plugin. Static pages were working as expected. Please could you provide concrete steps to reproduce the issue?
PostsRouteDetection event should not interfere with routing unless a page has already been defined to handle the matching slug (in Posts settings). I would like to fix this if it's definitely the plugin causing the problem.
I only notice this bug when the theme does not "yet" have the pages required by the plugin.
As soon as these are defined in the settings, there is no problem.
Reported via discord (@damsfx)
PostsRouteDetection.php
If the plugin have no settings defined (no matching page to show his components), it crashed the entire wn-pages-plugin.
Adding some page with matching components resolve the issue.
Maybe the plugin should use fall-back settings when these are not given.
The text was updated successfully, but these errors were encountered: