Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Remove the plt.show() calls in the plotting functions #32

Closed
RaverJay opened this issue Aug 16, 2022 · 3 comments
Closed

Suggestion: Remove the plt.show() calls in the plotting functions #32

RaverJay opened this issue Aug 16, 2022 · 3 comments

Comments

@RaverJay
Copy link

Hey there,

See title. This would allow the user to actually use the returned ax object, e.g. to plot more things into these Axes.
Currently the plt.show() command blocks this.

The usual pyplot way of things is to make the figure and axes, then plot stuff into it, customize the ticks etc, and then finally call
plt.show() or plt.savefig() - as the user's responsibility.

Also, it would be great to have more parameters, e.g. for figure size

Cheers

@tonigi
Copy link
Collaborator

tonigi commented Aug 18, 2022

I'm a bit baffled by the matplotlib library, but that sounds right. However, it would be a (small) breaking change, so I'm deferring it to the next major release.

@tonigi
Copy link
Collaborator

tonigi commented Aug 18, 2022

FWIW 0698942

@tonigi
Copy link
Collaborator

tonigi commented Sep 2, 2022

Now in 1.3.0

@tonigi tonigi closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants