Extra whitespaces at the end of callstack frames when file:line are not available

[derekbruening]

From timurrrr@google.com on September 08, 2011 08:34:49

See the lines below (^M was added by vim)

Error #1: UNADDRESSABLE ACCESS: reading 0x028a8ce6-0x028a8ce7 1 byte(s)^M
...
#11 base_unittests.exe!main [c:\chromium\src\base\test\run_all_unittests.cc:8]^M
#12 base_unittests.exe!__tmainCRTStartup [f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:266]^M
#13 base_unittests.exe!mainCRTStartup [f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:181]^M
#14 KERNEL32.dll!BaseThreadInitThunk ^M
#15 ntdll.dll!RtlInitializeExceptionChain ^M
#16 ntdll.dll!RtlInitializeExceptionChain ^M

Original issue: http://code.google.com/p/drmemory/issues/detail?id=584

[derekbruening]

From bruen...@google.com on September 08, 2011 07:55:09

the column-aligned format is for human consumption. for scripting perhaps you could just turn that feature off.

[derekbruening]

From timurrrr@google.com on September 08, 2011 08:18:11

for scripting perhaps you could just turn that feature off.
indeed.

the column-aligned format is for human consumption.
but anyways what's the point to add extra spaces at the end of a callstack line if there's nothing else to print on this line?

[derekbruening]

From bruen...@google.com on September 08, 2011 08:23:09

but anyways what's the point to add extra spaces at the end of a callstack line if
there's nothing else to print on this line?
simpler code to pad each field

[derekbruening]

From timurrrr@google.com on September 09, 2011 02:07:03

isn't it like
len1 = print_mod_fun();
print_padding(len1, desired);
if (file_and_line_known) {
print_file_and_line();
}
?
If this is the case then the change should be trivial..

[derekbruening]

From bruen...@google.com on September 09, 2011 06:35:17

https://code.google.com/p/drmemory/source/browse/trunk/common/callstack.c#499

[derekbruening]

From derek.br...@gmail.com on September 22, 2011 14:15:09

This issue was closed by revision r536 .

Status: Fixed