ipc tests failures: usage error, 2 UNADDRs, HANG

[derekbruening]

From bruen...@google.com on October 05, 2011 18:46:03

throwing all these into one issue, let's split it up as we figure out what the underlying issues are:

1. on the bot, which doesn't make any sense:
   Dr.M Usage error on option "-callstack_truncate_": unknown option: aborting

14:58:46 common.py [INFO] running e:\b\build\slave\chromium-dbg-win-drmemory-win-7\build\src\tools\valgrind....\third_party\drmemory\unpacked\bin\drmemory.exe -suppress e:\b\build\slave\chromium-dbg-win-drmemory-win-7\build\src\tools\valgrind\DrMemory\suppressions.txt -logdir c:\users\chrome~2\appdata\local\temp\vg_logs__ezjsb -batch -quiet -no_results_to_stderr -callstack_max_frames 40 -callstack_srcfile_prefix build\src,chromium\src,crt_build\self_x86 -callstack_truncate_below main,BaseThreadInitThunk,testing_Test_Run_,testing::internal_,MessageLoop::Run,RunnableMethod* -callstack_modname_hide .exe,chrome.dll -no_check_uninitialized -no_count_leaks -- src/build/Debug\ipc_tests.exe --gtest_print_time --gtest_filter=-IPCSyncChannelTest., timeout 10000 sec

2. unaddr seen when I run in cygwin shell:
   when I run no ipc tests (this one is in exclude list) it works, though I see:
   % PATH=/c/src/chromium/depot_tools:$PATH tools/valgrind/chrome_tests.bat --build_dir build/Release -t ipc --tool drmemory_full --gtest_filter="IPCSyncChannelTest.Simple"
   UNADDRESSABLE ACCESS: reading 0x00f4f04b-0x00f4f04c 1 byte(s) within 0x00f4f048-0x00f4f04c
   #0 __from_strstr_to_strchr [f:\dd\vctools\crt_bld\SELF_X86\crt\src\INTEL\strchr.asm:142]
   timurrrr/2010/i309-fix-suppression-assertions.diff #1 testing::internal::UnitTestOptions::FilterMatchesTest [testing\gtest\src\gtest.cc:501]
   Note: @0:00:03.426 in thread 5388
   Note: next higher malloc: 0x00f4f858-0x00f4f868
   Note: refers to 1 byte(s) beyond last valid byte in prior malloc
   Note: prev lower malloc: 0x00f4f030-0x00f4f04b
   Note: instruction: mov 0xfffffffc(%edx) -> %eax

3. when I don't specify a filter, from cmd, hangs here:
   [ RUN ] SyncSocketTest.SanityTest
   .\sync_socket_unittest.cc(188): error: Value of: retval
   Actual: false
   Expected: true

4. yet this works:
   ~/drmemory/git/build_drmemory/bin/drmemory.exe -no_check_uninitialized -no_count_leaks -batch -dr c:/src/dr/git/exports -- ./ipc_tests.exe --gtest_filter="-IPCSyncChannelTest.*"

though reports this in 4 different child processes:

Error #1: UNADDRESSABLE ACCESS: reading 0x00004648-0x0000464c 4 byte(s)
#0 ntdll.dll!LdrUnlockLoaderLock
#1 ntdll.dll!LdrUnlockLoaderLock
#2 ntdll.dll!RtlAllocateHeap
#3 ntdll.dll!RtlDeleteBoundaryDescriptor
#4 ntdll.dll!wcsnicmp
#5 KERNELBASE.dll!IsNLSDefinedString
#6 KERNELBASE.dll!GetModuleHandleA
#7 sophos_detoured.dll!spmaa_finalise2
#8 sophos_detoured.dll!spmaa_finalise2
#9 sophos_detoured.dll!spmaa_finalise2
#10 sophos_detoured.dll!spmaa_finalise2
#11 ntdll.dll!LdrShutdownProcess
Note: @0:00:01.601 in thread 5104
Note: instruction: inc 0x10(%eax) -> 0x10(%eax)

Original issue: http://code.google.com/p/drmemory/issues/detail?id=613

[derekbruening]

From bruen...@google.com on October 05, 2011 15:46:18

Owner: rnk@google.com

[derekbruening]

From bruen...@google.com on October 05, 2011 15:47:26

Summary: ipc tests failures: usage error, 2 UNADDRs, HANG

[derekbruening]

From bruen...@google.com on October 05, 2011 17:09:57

update: I can't repro the hang with either release or debug chrome under drmem

[derekbruening]

From timurrrr@google.com on October 06, 2011 03:23:59

2. strstr unaddr seen when I run in cygwin shell:
   Yeah, I've seen this locally too. Not a high priority (doesn't happen on the bots) though sounds wrong we don't replace this strstr.

update: I can't repro the hang with either release or debug chrome under drmem
The bots run pure Debug build, without our custom build flags

[derekbruening]

From bruen...@google.com on October 06, 2011 10:53:11

the unaddr in 4) above is almost certainly the same issue as issue #533 , the unaddr in issue #534 , and the one I see trying to repro issue #610 , so let's split that out of here

[derekbruening]

From bruen...@google.com on October 06, 2011 16:13:00

#2 (strchr) split as issue #617

[derekbruening]

From rnk@google.com on October 07, 2011 14:39:12

This issue was closed by revision r553 .

Status: Fixed

[derekbruening]

From timurrrr@google.com on October 11, 2011 05:08:10

Still hangs, XP only - filed issue #621