Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when Dynflow::Action::Timeouts::Timeout happens after action is completed already #381

Closed
jeremylenz opened this issue Mar 1, 2021 · 0 comments · Fixed by #383
Closed
Milestone

Comments

@jeremylenz
Copy link

ERROR -- /parallel-executor-core: no manager for Dynflow::Director::Event[request_id: e8842967-abe0-46cf-aa2e-0aa98eaa0145-14, execution_plan_id: 9a83e650-8ff1-4a71-86f9-275e30d7037c, step_id: 2, event: Dynflow::Action::Timeouts::Timeout, result: #<Concurrent::Promises::ResolvableFuture:0x000000000ed17b40 pending>] (Dynflow::Error)

See https://projects.theforeman.org/issues/31853

See https://github.com/Katello/katello/blob/090f510fe091c2539c5f83e65e802c8cd9d5e7c5/app/lib/actions/katello/agent_action.rb#L46

When the time runs out, an event is sent to the action. If the action finishes in the mean time, this error gets logged because dynflow tries delivering an event to an execution plan that is not running anymore.

Dynflow should have a way to handle this, perhaps

  1. provide a way to ignore certain events and avoid throwing errors
  2. make Timeouts cancellable in some way
@adamruzicka adamruzicka added this to the v1.5.0 milestone Mar 18, 2021
@adamruzicka adamruzicka linked a pull request Mar 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants