Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: read MC Version from filename #55

Open
Keridos opened this issue Dec 6, 2014 · 1 comment
Open

Feature Request: read MC Version from filename #55

Keridos opened this issue Dec 6, 2014 · 1 comment

Comments

@Keridos
Copy link
Contributor

Keridos commented Dec 6, 2014

With some simple regular expressions you might be able to pull the supported Minecraft Version from the filename. I usually name my mods like FloodLights-MC1.7.10-0.3.5-40.jar. MC1.7.10 is the mc version, 0.3.5 the mod version and 40 is the build number on my jenkins. It should be rather easy to grab the MC version from that. MC[0-9].[0-9].[0-9]{2} or something like that should match the version then just add in groups and you got the versions in 3 variables.

@coolAlias
Copy link

Every mod author seems to have a different naming convention, though. I, for example, put the MC version first: "1.7.10-zeldaswordskills-1.0.jar", and many don't put the MC version at all (though they should).

Would you handle multiple scenarios, or require all authors to conform to one standard?

Also, MC version is already handled in the JSON, so what extra benefit would this feature provide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants