Some recommended style issues

[ocaisa]

@dwhswenson raised some style issues when reviewing the code:

there are a lot of kwarg updates that might be cleaned up with a function like

# instead of making a dictionary to update with all at once, call update_kwargs for each name
def update_kwargs(kwargs, obj, name, default):
    kwargs.update({name: getattr(obj, name, getattr(kwargs, name, default))})

The idiom with the nested getattrs is repeated several times, and requires the use of name 3 times. It is also the source of some of the longer lines (not to mention some harder-to-read and somewhat inconsistent formatting from black).

[dwhswenson]

To clarify, the sorts of things that I thought were inconsistent in black's formatting are lines like these:

jobqueue_features/jobqueue_features/decorators.py

Lines 126 to 133 in 8d3725f

	"mpi_launcher": getattr(
	cluster, "mpi_launcher", getattr(kwargs, "mpi_launcher", MPIEXEC)
	),
	"mpi_tasks": getattr(
	cluster,
	"mpi_tasks",
	getattr(kwargs, "mpi_tasks", self.default_mpi_tasks),
	),

In the first dict entry, all the arguments to getattr are on one line. In the second entry, each argument has its own line. It takes a second to see that these are all doing essentially the same thing; putting the behavior in a function would make it more readable, in my opinion. Also, easier to write: only need to include the string for the name once, instead of 3 times.

[AdamWlodarczyk]

Agree. String literals should be introduced once.

[ocaisa]

This is also resolved in #9