Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters & and " not properly escaped #772

Closed
spathi85 opened this issue Mar 6, 2018 · 7 comments
Closed

Characters & and " not properly escaped #772

spathi85 opened this issue Mar 6, 2018 · 7 comments

Comments

@spathi85
Copy link

spathi85 commented Mar 6, 2018

Hi,

since an update last year (I would say around March 2017) the characters & and " are displayed as & and " in the epg of streaming clients. On the receiver and directly in the webinterface everything ist displayed correctly.

Here's an example from Kodi 17.6 with PVR Plugin for Vu+:
img_20180306_210158

And one from "Dream Droid" for Android:
screenshot_20180306-210423

Thanks.

@jbleyel
Copy link
Contributor

jbleyel commented Mar 6, 2018

These encoded signs are valid for xml and we have no intention to change this.
Some foreign language needs this to prevent xml parsing errors.
You have to fix this issue in the 3rd party applications.

@zehnerGIT
Copy link
Contributor

zehnerGIT commented Mar 31, 2018

Sorry to bring this up again, but I've checked the output of OpenWebIf (openatv 6.1.0, openwebif 1.3.0) and it's correct to replace some signs with their xml or html entities, but OpenWebIf replaces the already escaped characters a second time and that's the problem here.
If I look at epgservice, I can find entries like
Linda Hunt (Henrietta &amp;quot;Hetty&amp;quot; Lange) in <e2eventdescriptionextended> That's because the correct entity &quot; is escaped a second time and the result is &amp;quot;

@jbleyel
Copy link
Contributor

jbleyel commented Mar 31, 2018

The code inside of openwebif is here. ->

https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/blob/master/plugin/controllers/models/services.py#L46

!!CAUTION!!
The result needs to be encoded for valid json and xml results.

Please provide channel name and date of some epg item for testing.
This example needs to be sat ( astra 19,2 ) and in some days.

@jbleyel jbleyel reopened this Mar 31, 2018
@zehnerGIT
Copy link
Contributor

Thanks for the feedback

I've tested the url http://vuplus/web/epgservice?sRef=1%3A0%3A1%3A445E%3A453%3A1%3AC00000%3A0%3A0%3A0%3A (that's Kabel 1 for me) and there are many entries (e.g. a reocurring entry is Navy CIS: L.A. with the line Linda Hunt (Henrietta &amp;quot;Hetty&amp;quot; Lange)). My tests are on Ubuntu with CURL, WGET, Chromium and Firefox and all show the same behaviour.

@jbleyel
Copy link
Contributor

jbleyel commented Mar 31, 2018

I think i have found the root cause.
The Cheetah template to build the xml have a feature named websafe.
This filter encodes the text again and therefore we have double encoding.
I will try to fix this.

@jbleyel
Copy link
Contributor

jbleyel commented Apr 1, 2018

please check the latest version

@jbleyel jbleyel closed this as completed Apr 1, 2018
@zehnerGIT
Copy link
Contributor

zehnerGIT commented Apr 24, 2018

Thanks for the fix and sorry for the delay, but my box has gone temporary EOL and only yesterday I received a (propably last) update.

I've checked with KODI as client and everything works as expected, there are no longer wrong escape signs in the EPG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants