Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect C:N ratios and C:P causing balance errors in transient simulations #6368

Open
dmricciuto opened this issue Apr 25, 2024 · 0 comments · May be fixed by #6370
Open

Incorrect C:N ratios and C:P causing balance errors in transient simulations #6368

dmricciuto opened this issue Apr 25, 2024 · 0 comments · May be fixed by #6370
Assignees

Comments

@dmricciuto
Copy link
Contributor

This was noticed in the v2 offline feature simulations. It seems to be related to the bolded section in the code below from components/elm/src/biogeochem/ComputeSeedMod.F90 dealing with allocating seed C, N and P to display, storage and xfer components of the leaf.
pleaf, pstorage, and pxfer are computed for C,N and P separately. If tot_leaf is very small these proportions may be different for C,N,P, causing C:N and C:P ratios to diverge from the expected fixed values in the parameter file. In rare cases, this leads to negative N or P and eventual balance errors. Removing the bolded code and always allocating 100% to either leaf or storage seems to fix this issue.

if (tot_leaf == 0._r8 .or. ignore_current_state) then
if (veg_vp%evergreen(pft_type) == 1._r8) then
pleaf = 1._r8
else
pstorage = 1._r8
end if
else
pleaf = leaf /tot_leaf
pstorage = leaf_storage/tot_leaf
pxfer = leaf_xfer /tot_leaf

end if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant