Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid testing duplication for packages zppy uses #537

Open
3 tasks done
Tracked by #553
forsyth2 opened this issue Dec 8, 2023 · 0 comments
Open
3 tasks done
Tracked by #553

Avoid testing duplication for packages zppy uses #537

forsyth2 opened this issue Dec 8, 2023 · 0 comments
Labels
Testing Files in `tests` modified

Comments

@forsyth2
Copy link
Collaborator

forsyth2 commented Dec 8, 2023

Request criteria

  • I searched the zppy GitHub Discussions to find a similar question and didn't find it.
  • I searched the zppy documentation.
  • This issue does not match the other templates (i.e., it is not a bug report, documentation request, feature request, or a question.)

Issue description

The zppy tests essentially test every package used by zppy in addition to zppy itself. What exactly should zppy testing focus on, as to not duplicate individual package tests?

Most notably, the image diff test is found in both E3SM Diags and zppy. Is it really necessary to have that test in both packages? Where does it really belong? (Note that there are plans to test metrics rather than image diffs: E3SM-Project/e3sm_diags#756, #536)

@forsyth2 forsyth2 added the Testing Files in `tests` modified label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Files in `tests` modified
Projects
None yet
Development

No branches or pull requests

1 participant