New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padulles-Amphlett B #137
Padulles-Amphlett B #137
Conversation
@sadrasabouri @sarminh @kasraaskari |
Links : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes are approved.
RUN python3 -m pip install pip --upgrade | ||
RUN python3 -m pip install opem | ||
RUN python3.6 -m pip install pip --upgrade | ||
RUN sleep 40 && python3.6 -m pip install opem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this sleep for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To wait for pypi loading
@sepandhaghighi Please add the following document to the reference section of this model. This is exacty the B formula reference, which you can find it at the reference section of both Amphlett and Larminie-Dicks Static models too. |
@kasraaskari Thanks for your review ;-) |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?