Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padulles-Amphlett B #137

Merged
merged 16 commits into from Aug 18, 2020
Merged

Padulles-Amphlett B #137

merged 16 commits into from Aug 18, 2020

Conversation

sepandhaghighi
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Padulles-Amphlett dynamic model modified
  • Travis and Appveyor configs updated
  • Dockerfile updated

Any other comments?

@sepandhaghighi
Copy link
Contributor Author

@sadrasabouri @sarminh @kasraaskari
Please review this PR ;-)

@sepandhaghighi
Copy link
Contributor Author

Links :

Copy link

@sarminh sarminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are approved.

RUN python3 -m pip install pip --upgrade
RUN python3 -m pip install opem
RUN python3.6 -m pip install pip --upgrade
RUN sleep 40 && python3.6 -m pip install opem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this sleep for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To wait for pypi loading

@kasraaskari
Copy link
Contributor

Links :

@sepandhaghighi Please add the following document to the reference section of this model. This is exacty the B formula reference, which you can find it at the reference section of both Amphlett and Larminie-Dicks Static models too.
Larminie, J., Dicks, A., & McDonald, M. S. 2003. Fuel cell systems explained (Vol. 2, pp. 207-225). Chichester, UK: J. Wiley. doi: 10.1002/9781118706992.

@sepandhaghighi
Copy link
Contributor Author

Links :

@sepandhaghighi Please add the following document to the reference section of this model. This is exacty the B formula reference, which you can find it at the reference section of both Amphlett and Larminie-Dicks Static models too.
Larminie, J., Dicks, A., & McDonald, M. S. 2003. Fuel cell systems explained (Vol. 2, pp. 207-225). Chichester, UK: J. Wiley. doi: 10.1002/9781118706992.

@kasraaskari Thanks for your review ;-)
I update document in 8df9b81 and a2e838a
@sarminh @sadrasabouri @kasraaskari if everything is okay merge this PR.

@sadrasabouri sadrasabouri merged commit b89cd82 into develop Aug 18, 2020
@sepandhaghighi sepandhaghighi deleted the Padulles_Amphlett_B branch August 19, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants