Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Test #154

Merged
merged 4 commits into from Apr 10, 2021
Merged

Notebook Test #154

merged 4 commits into from Apr 10, 2021

Conversation

sepandhaghighi
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • notebook_check.py script added
  • -q flag added to matplotlib installation line in notebooks

Any other comments?

@codecov-io
Copy link

Codecov Report

Merging #154 (ed2d658) into develop (5af227c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    92.70%   92.70%           
========================================
  Files           22       22           
  Lines         1657     1657           
========================================
  Hits          1536     1536           
  Misses         121      121           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af227c...ed2d658. Read the comment docs.

@sepandhaghighi
Copy link
Contributor Author

@sadrasabouri Please review this PR 🥇

@sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

* `notebook_check.py` script added

* `-q` flag added to `matplotlib` installation line in notebooks

Any other comments?

-q flag added because of this, right?

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I've left a question to make the pull request well documented.

@sadrasabouri sadrasabouri merged commit a056fe7 into develop Apr 10, 2021
@sadrasabouri sadrasabouri deleted the notebook_test branch April 10, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants