Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Modification #158

Merged
merged 9 commits into from May 29, 2021
Merged

Menu Modification #158

merged 9 commits into from May 29, 2021

Conversation

sepandhaghighi
Copy link
Contributor

@sepandhaghighi sepandhaghighi commented May 28, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Menu modified
  • description_print function modified
  • description_control function modified

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #158 (69cb1a5) into develop (9b3a9ff) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    92.70%   92.71%   +0.01%     
===========================================
  Files           22       22              
  Lines         1657     1658       +1     
===========================================
+ Hits          1536     1537       +1     
  Misses         121      121              
Impacted Files Coverage Δ
opem/Test/test_Functions.py 100.00% <ø> (ø)
opem/Functions.py 88.66% <50.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3a9ff...69cb1a5. Read the comment docs.

@sepandhaghighi
Copy link
Contributor Author

@sadrasabouri Please review this PR 🥇

@@ -608,6 +608,7 @@ def description_print(Analysis_Name, Description_Dict, Width=100):
:return: None
"""
line()
print(Analysis_Name.replace("_", " ") + " : \n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK but shouldn't we see some changes in tests too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at test_Functions.py changes

@sadrasabouri sadrasabouri merged commit ff11924 into develop May 29, 2021
@sepandhaghighi sepandhaghighi deleted the menu_modification branch May 29, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants