Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev xxc script #5

Merged
merged 7 commits into from Dec 14, 2021
Merged

Dev xxc script #5

merged 7 commits into from Dec 14, 2021

Conversation

incandescentxxc
Copy link
Member

  1. Completed DataZoom and VisualMap Option Interface and Class
  2. Finished WorldPopulationTest
  3. Partially Finished BeijingAQITest with some potential problems to be discussed.

@incandescentxxc incandescentxxc changed the base branch from dev-jzx to dev December 13, 2021 06:14
@icepear-jzx
Copy link
Member

In general, your implementation is right, but there are some minor code style problems.

@incandescentxxc
Copy link
Member Author

incandescentxxc commented Dec 13, 2021 •
edited

Styling issues have been resolved in the last commit. Some other problems left in BeijingAQITest should be discussed before continuing.

@incandescentxxc
Copy link
Member Author

Finish beijing aqi testing

@icepear-jzx icepear-jzx merged commit 09a597a into dev Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icepear-jzx icepear-jzx icepear-jzx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@incandescentxxc @icepear-jzx