Exception error in RouteDetails()

[Darkcyde13]

EDDI version in which issue is found

v3.5.1

VoiceAttack version in which issue is found (as applicable)

N/A

Steps to reproduce

I have taken eight missions, spread over six different systems.
Using a new copy of the EDDI default personality, I created a new script and put the following in it:-
{set temp to RouteDetails('route'}
I then run the script.

Expected

This is the speech I get when I use my own version of the Nearest Neighbour route plotting from my own personality:-
"Route recalculated for 6 systems. Total distance is 84.0 lightyears. Initial destination has been updated to Ogmar. Awaiting orders. Launch to engage auto route plotting system."
I would expect something very similar to this using the EDDI RouteDetails() function.

Observed

Instead, I get this:-
"There is a problem with the: New function script. An entry with the same key already exists."

Investigation

I've been trying to rebuild and refine my version of the mission scripts for my personality, and I wanted to see if I could replace my version of the Nearest Neighbour plotting with the built in EDDI function.

All was going well, until I selected a new set of eight missions over six systems (I've mostly been trying a few missions over only 1-2 systems). I kept getting the observed error, so to eliminate any possibility it was my personality, I made a fresh copy of the default, and created a new script with just that one line in it. I've even reloaded EDDI several times, both with and without Voice Attack, but I always get the same error.

So, I've reloaded EDDI standalone, enabled verbose logging, and rerun the test script. Please find attached copies of the eddi.log and the missions.json, just in case you need that too.

eddi.log
missionmonitor.zip

[Hoodathunk]

Thanks for including your missionmonitor.json file, DC... That was essential.

I'm able to reproduce the exception and expect to have a fix in for next update.

[Darkcyde13]

Cool, thanks Hoodathunk. Out of curiosity, what is causing the error? Is it something to do with the number of different systems? I noticed in the log, that it went through a couple of route iterations before the error occurred, so I was wondering if it was too many systems?

[Hoodathunk]

Nope, nothing like that. Interesting edge case, which I should have protected against in the first place, so an otherwise easy fix... usually are.

VB & TK are keen on getting the fix in 3.5.2 for the Ship Monitor crash out ASAP, so we'll get this fix out in 3.5.3, close on its heels.

[richardbuckle]

We've extracted the fix to PR #1654 and I've agreed it's low enough risk to be merged it for 3.5.2.