Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"FSD engaded" should report "Arrival star is not scoopable" if the ship has a fuel scoop #2494

Closed
slippycheeze opened this issue Jan 16, 2023 · 1 comment
Labels
9. enhancement The behaviour is as specified, but we would like to modify or extend the spec.

Comments

@slippycheeze
Copy link
Contributor

What happens now

The "FSD engaged" script always reports "Arrival star is not scoopable" when this is true.

What I'd like to happen

On most of my ships, which do have a fuel scoop, it should continue to behave as-is.
On my rescue ship, which does not have a fuel scoop, there is no need for me to know that, so omit that fact.

How it can happen

I implemented this as:

          |elif find(scoopables, event.stellarclass) = -1:
+             {for compartment in ship.compartments:
+                 {if compartment.module && compartment.module.enabled && compartment.module.basename = "FuelScoop":
                    {Occasionally(2, "Information: ")}
                    Arrival star is not scoopable.
+                 }
+             }
        }

EDDI Version

v.4.0.2

@Tkael Tkael added the 9. enhancement The behaviour is as specified, but we would like to modify or extend the spec. label Jan 17, 2023
@Darkcyde13
Copy link

I have this in my FSD engaged script. It's very similar to your suggestion,

        |elif find(scoopables, event.stellarclass) = -1:
            {for compartment in ship.compartments:
                {if compartment.module.basename = "FuelScoop":
                    {Occasionally(2, "Information:")}
                    Arrival star is not scoopable.
                }
            }
        }

@Tkael Tkael closed this as completed in c4fc835 Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9. enhancement The behaviour is as specified, but we would like to modify or extend the spec.
Projects
None yet
Development

No branches or pull requests

3 participants