Rename the _()
translation function
#1812
Labels
enhancement
Plugins
Anything related to plugins
python
Pull requests that update Python code
Staged
Feature Complete and in Testing for Next Release
Translations
Projects
Milestone
An unfortunate side-effect of forcing
_()
intobuiltins
for translation of strings is that it means the_
for things like "I don't care about this return value" clashes. In general it was a REALLY bad choice given the uses of_
normally.Here I've changed
new_data
in the function call to_
. After this the use of_("string to be translated")
breaks:Proposal:
Change the translation
_()
to_t()
- it's only one extra character.Issues:
minor - PLUGINS.md mentions manually setting this up (does that code even work ?), that needs updating. But as plugins would have to manually set things up in this manner nothing will break by changing this in core code.
Follow-ups:
Identify any places where
_
as "throw this away" would be appropriate and update them. There's at least some killswitch related code.Check over all the developer documentation to be sure it's up to date with the change.
The text was updated successfully, but these errors were encountered: