Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MacOS Support #2186

Open
Rixxan opened this issue Mar 27, 2024 · 3 comments · Fixed by #2187
Open

Remove MacOS Support #2186

Rixxan opened this issue Mar 27, 2024 · 3 comments · Fixed by #2187
Assignees
Labels
code cleanup Cleaning up code enhancement OS Issue python Pull requests that update Python code Staged Feature Complete and in Testing for Next Release
Milestone

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Mar 27, 2024

Describe the enhancement

Development of Elite Dangerous on MACos ended over half a decade ago. Recent changes to the MacOS NSSound API may have resulted in EDMC no longer functioning. There is no functional manner to play on MacOS natively, and known MaCoS users have reported using Wine and the distributed EXEs to utilize EDMC and Elite.

macOS support should be formally removed. As this does not actually change the available API endpoints (See EDMC channel discussion in EDCD Discord) this does not particularly necessitate a major point version change.

Additional context

This will also substantially reduce code complexity by removing specific caveats for Darwin code that no longer need to exist. Deprecation regarding public API available endpoints should be reviewed.

@Rixxan Rixxan added enhancement code cleanup Cleaning up code python Pull requests that update Python code OS Issue labels Mar 27, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Mar 27, 2024
@Rixxan Rixxan added this to Pending in Enhancement Tracker via automation Mar 27, 2024
@Rixxan Rixxan self-assigned this Mar 27, 2024
@Athanasius
Copy link
Contributor

Athanasius commented Mar 27, 2024

  1. To be a pedant it's "macOS", not "MacOS" ;)
  2. Yup, it's time for this to just die. Unless someone with actual macOS hardware wants to step up to help develop patches/PRs as needed. I've not seen anyone volunteer for that. Whilst it's possible to get a macOS image to boot under, e.g. VirtualBox, there's no legal way to do that without also owning an applicable piece of Apple hardware (for access to the OS install images).
  3. Any user being perverse by wanting to run the game and EDMC on Apple hardware can do so using the windows installer via WINE or other such emulation/virtualisation. They just need to be sure the Windows version they use for that is supported.

@Rixxan
Copy link
Contributor Author

Rixxan commented Mar 27, 2024

  1. To be a pedant it's "macOS", not "MacOS" ;)

Updated to be much, much worse <3

@Rixxan Rixxan moved this from Pending to In Progress in Enhancement Tracker Mar 28, 2024
@Rixxan Rixxan added this to In Progress in General Code Cleanups Mar 28, 2024
@Rixxan Rixxan linked a pull request Mar 28, 2024 that will close this issue
@Rixxan Rixxan added the Staged Feature Complete and in Testing for Next Release label Apr 6, 2024
@Rixxan Rixxan moved this from In Progress to Complete in Enhancement Tracker Apr 6, 2024
@Rixxan Rixxan moved this from In Progress to Done in General Code Cleanups Apr 6, 2024
@Rixxan Rixxan removed the Staged Feature Complete and in Testing for Next Release label Apr 12, 2024
@Rixxan
Copy link
Contributor Author

Rixxan commented Apr 12, 2024

OK. #2187 broke the new feature in #2183. Reverting and trying again from there.

@Rixxan Rixxan added the Staged Feature Complete and in Testing for Next Release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code enhancement OS Issue python Pull requests that update Python code Staged Feature Complete and in Testing for Next Release
2 participants