Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonUtilities::getTaxonTable #153

Open
daijiang opened this issue Feb 17, 2024 · 4 comments
Open

neonUtilities::getTaxonTable #153

daijiang opened this issue Feb 17, 2024 · 4 comments

Comments

@daijiang
Copy link

neon_taxon_table <- neonUtilities::getTaxonTable(

neonUtilities::getTaxonTable needs to be replaced to neonOS::getTaxonList

@clnsmth
Copy link
Contributor

clnsmth commented Feb 17, 2024

Hey @sokole. Would you be able to take a look at this issue? I'm not entirely sure if our integration tests cover it adequately.

Which reminds me, it might be a good idea for us to go over our test suite together and see if there are any adjustments we could make to be more confident in applying changes to the ecocomDP code base. What do you think?

Thanks a bunch for your help!

@sokole
Copy link
Collaborator

sokole commented Feb 17, 2024

I made this update in the pull request last summer before ESA. The fix is in the dev branch on my fork if not already merged into the dev branch on EDIorg.

@clnsmth
Copy link
Contributor

clnsmth commented Feb 19, 2024

Heads up @sokole, I don't see @daijiang's recommended code change in the development branch of EDIorg.

@daijiang
Copy link
Author

The code has been updated in other R scripts. It is just this specific one that was not updated; and this file was not used in the neonDivData project I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants