Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s) for Highway on neoverse_v1 #469

Open
bedroge opened this issue Feb 9, 2024 · 2 comments
Open

Failing test(s) for Highway on neoverse_v1 #469

bedroge opened this issue Feb 9, 2024 · 2 comments
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io aarch64 related to Arm 64-bit targets (aarch64) tests Related to software testing

Comments

@bedroge
Copy link
Collaborator

bedroge commented Feb 9, 2024

In #419 we encountered a failing test for Highway 1.0.3 on neoverse_v1:

        211 - HwyBlockwiseShiftTestGroup/HwyBlockwiseShiftTest.TestAllShiftRightLanes/SVE_256  # GetParam() = 33554432 (Subprocess aborted)

While debugging things interactively, sometimes this one failed in the same way:

        212 - HwyBlockwiseShiftTestGroup/HwyBlockwiseShiftTest.TestAllShiftRightLanes/SVE  # GetParam() = 134217728 (Subprocess aborted)

An issue has been created upstream, and according to the developer this can be safely ignored, since the expected value itself is wrong:
google/highway#1938

A hook will be added to exclude these tests on neoverse_v1.

@bedroge bedroge added aarch64 related to Arm 64-bit targets (aarch64) tests Related to software testing 2023.06-software.eessi.io 2023.06 version of software.eessi.io labels Feb 9, 2024
@boegel
Copy link
Contributor

boegel commented Feb 11, 2024

workaround implemented in hooks in #419

@bedroge
Copy link
Collaborator Author

bedroge commented Apr 3, 2024

Highway version 1.0.4 (with GCCcore 12.3.0) also has test-related issues on neoverse_v1: they even fail to build. As a workaround --optarch=GENERIC could be used to complete the build, but 3 out of 843 tests will still fail to run. We could also set the CMake configure flag -DHWY_ENABLE_TESTS=OFF to disable building (and running) the tests, with the advantage that we still get an optimized (but untested) build.

An almost similar issue also shows up for neoverse_n1, and disabling the tests doesn't solve the issue there. For that one, setting --optarch=GENERIC does make the build succeed, and even the tests all succeed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io aarch64 related to Arm 64-bit targets (aarch64) tests Related to software testing
Projects
None yet
Development

No branches or pull requests

2 participants