Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still storing some non-tracking domains #1864

Open
ghostwords opened this issue Feb 12, 2018 · 3 comments
Open

Still storing some non-tracking domains #1864

ghostwords opened this issue Feb 12, 2018 · 3 comments
Labels
bug heuristic Badger's core learning-what-to-block functionality

Comments

@ghostwords
Copy link
Member

ghostwords commented Feb 12, 2018

It looks like we are still recording non-tracking subdomains of tracking domains. This should be fewer non-tracking domains than before, but still, we shouldn't store any.

You can see if you have any such domains by running the following code in your Badger's background page:

(function () {
  const actionMap = badger.storage.getBadgerStorageObject("action_map"),
    actions = actionMap.getItemClones();

  for (const domain in actions) {
    const map = actions[domain];
      if (map.userAction == "" && map.heuristicAction == "") {
        console.log(domain);
      }
    }
}());

This follows up on #1795 (comment) and #1446.

@ghostwords
Copy link
Member Author

ghostwords commented Sep 1, 2019

One complication is that we don't want to keep rechecking DNT on blocked domains.

We store last check time in the same action_map data structure. Discarding (never storing) non-tracking subdomains will discard these timestamps and precipitate DNT checks next time these subdomains are encountered and blocked (because of an already-blocked parent domain).

A potential fix would be to move last DNT check timestamps out of action_map into their own data structure subject to periodic cleanup.

@ghostwords
Copy link
Member Author

This might be related to #888.

@ghostwords
Copy link
Member Author

Firefox doesn't seem to enforce any storage.local-specific quotas at this time: #2464 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug heuristic Badger's core learning-what-to-block functionality
Projects
None yet
Development

No branches or pull requests

1 participant