Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Strip tracking from out.reddit.com #2194

Open
jleclanche opened this issue Oct 12, 2018 · 6 comments
Open

Suggestion: Strip tracking from out.reddit.com #2194

jleclanche opened this issue Oct 12, 2018 · 6 comments
Labels
enhancement first-party relating to first-party scripts help wanted

Comments

@jleclanche
Copy link

Reddit mangles links in its new UI.

For example, if I click here:

https://www.reddit.com/r/books/comments/9nl70u/incarcerated_pennsylvanians_now_have_to_pay_150/

And then I click on the URL:
image

It redirects me to https://out.reddit.com/t3_9nixiz?url=https%3A%2F%2Fwww.washingtonpost.com%2Famphtml%2Fopinions%2Fincarcerated-pennsylvanians-now-have-to-pay-150-to-read-we-should-all-be-outraged%2F2018%2F10%2F11%2F51f548b8-cbd9-11e8-a85c-0bbe30c19e8f_story.html&token=XXXXXXXXXXXXXXXXXXXXXXXXXXXX-XXXXXXXXXXX&app_name=desktop2x&user_id=XXXXXXX

This behaviour can be disabled in the Privacy settings if you have an account:
https://www.reddit.com/settings/privacy

image

@ghostwords ghostwords added enhancement first-party relating to first-party scripts labels Oct 12, 2018
@bcyphers
Copy link
Contributor

Thanks for pointing this out! This should be pretty simple to do given the infrastructure from #2016.

@mijiturka
Copy link
Contributor

mijiturka commented Mar 12, 2019

I've made a change here that seems to work (based on my manual testing in Firefox and Chrome). Working on adding unit tests now.

@bcyphers
Copy link
Contributor

Thanks @mijiturka. When you're happy with it, make a pull request and assign me as the reviewer.

@jleclanche
Copy link
Author

@mijiturka @bcyphers was this ever merged in?

@ghostwords

This comment has been minimized.

@ghost
Copy link

ghost commented Apr 15, 2021

This still happens without an account. It affects the main www.reddit.com site, not old.reddit.com

The opt-put in the account settings works as expected on the main site when logged in.

Page used to test: https://www.reddit.com/r/DataPolice/comments/hqlygx/eff_launches_searchable_database_of_police/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement first-party relating to first-party scripts help wanted
Projects
None yet
Development

No branches or pull requests

4 participants