Browser crash on Chrome 72+ #2249
Comments
|
This is completely unacceptable. I lost like 60 tabs. For extension to break particular site is still kind of tolerable. But for extension to crash whole Chrome is UNACCEPTABLE. Took me a while till I figured out it was privacy badger becuase i had it disabled just for this site and it still crashed Chrome. WTF??? You really need to rethink how you are developing this extension. I removed it and removed it for good! GOOD RIDDANCE |
|
Hello and sorry for your frustration! I'll see if there is anything we can do, but Privacy Badger is a standard Chrome extension. There isn't anything browser extensions should be able to do to cause the browser to crash. Unfortunately, you seem to have run into a browser bug. Please note that you are probably more likely to run into browser bugs using the beta version of the browser. |
|
Why are you misleading users that your extension can be disabled per site when it still crashes Chrome? The only way to get around it is to completely disable extension. That erodes trust in your extension. You are still doing something behind the scenes even when disabled per site. For extension built around privacy and transparency this is sad. |
|
Here is a question: what is this extension trying to do when it is disabled for a site and you visit disabled site? Lets see if you are going to give transparent answer. |
|
Privacy Badger shouldn't modify the page in any way when Privacy Badger is disabled on that page. Privacy Badger still does some bookkeeping (for example) before it gets to the "am I disabled here?" check though. But again, nothing Privacy Badger (or any other standard Chrome extension) does should be capable of crashing the browser. The fact that the browser did crash says this is a browser bug. It would be good to tell Chrome about the bug and help them fix it before more users run into it. |
|
If you keep regular backups of your Chrome profile folder, you should be able to restore your Chrome tabs from that backup. If you don't keep backups, did Chrome not ask you to restore tabs when reopened? |
|
What bookkeeping consists of? Do not point me to the code but explain yourself. What kind of tracking this extension does? Regarding tabs took me 20-30 Chrome crashes till I figured out what tab was crashing and what extension was responsible and in the meantime lost the tabs. |
|
It looks like other users are reporting crashes in error reports:
|
ghostwords
changed the title
|
@misternop Privacy Badger is an open source extension developed by a non-profit organization. Privacy Badger doesn't track its users. I understand you are upset, but please take a step back for a moment. I'd like to figure out what causes these crashes and get Chrome to fix them and/or work around them in Privacy Badger in the meantime. |
|
What bookkeeping consist of? |
|
Privacy Badger needs to figure out which requests your browser makes belong to the site you are on, and which do not. Out of the ones that do not belong to the site you are on (third-party requests), Privacy Badger needs to figure out if they track you or not. Once Privacy Badger sees tracking several times, Privacy Badger will learn to block those requests. When Privacy Badger is disabled, it still needs to know things like when you navigate away from the site you are on (so that Badger can be ready to be active and block requests on sites where it is enabled). It's also helpful to know which third-party domains are present on the current site so that if there is a problem with the site, and you choose to report this problem to us, we will see which third-parties you ran into on that page. Again, Privacy Badger doesn't track you in any way. Could you provide steps that crash Chrome 72 every time? I'm having trouble reproducing. |
|
I was able to repro by opening that link in a bunch of tabs, and closing them in various states of loading. This looks like http://crbug.com/915908 which I fixed yesterday and should be fixed in the latest Canary (and should be in the next Beta/Dev release). Until then you can go to chrome://flags/#network-service and set "Enable network service" to disabled, and the crash should not happen anymore. |
|
When I click on your crbug link I get Reason: User is not allowed to view this issue. |
|
Ah sorry, looks like that bug is restricted. Anyway, either using Canary/Stable or turning off "Enable network service" should work around the issue until the next Beta. |
|
When bug like this is restricted is it because it can be exploited and you guys don't want to share exactly what is bug about? |
|
Thank you @clarkduvall! @misternop Sorry again for the hassle! I understand losing all your tabs is really frustrating. I sometimes end up having to restore my tabs from a recent backup by shutting down Chrome, replacing the Chrome profile folder with the one from the backup, and starting Chrome. |
|
@ghostwords you are a nice person, calm and collected. Losing tabs was a side issue. I can't remember last time in many many years (if ever) that extension crashed Chrome like this. It was painful figuring out what was at least one of the causes. I fully support your and your team efforts at EFF. My apologies for quite a reaction I had. Unfortunately I wont be reinstalling this extension even though I still believe you guys do amazing work for the little guy. Good luck to you. |
|
Thanks! I suggest uBlock Origin, which is an excellent privacy extension both with and without Privacy Badger. Feel free to let me know how we can do better with Privacy Badger. This crash wasn't caught in our manual testing or automated tests, unfortunately. |
Can confirm this solves the issue. |
|
What does #network-service do and why is that bug restricted? |
|
Here's some more info on Network Service: https://docs.google.com/document/d/1wAHLw9h7gGuqJNCgG1mP1BmLtCGfZ2pys-PdZQ1vg7M/edit All crash bug reports are restricted by default. |
|
Resolving as I haven't received any new reports in a while. |
What is your browser and browser version?
Chrome Beta 72.0.3626.17 (Official Build) beta (64-bit)
What is broken and where?
worldoftanks.eu seems all pages from forums to other completely crashes chrome can't do anything
The text was updated successfully, but these errors were encountered: