-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo replacement widget breaks background autoplay videos #2281
Comments
Thank you for the report! It looks like we have to reset the Or, figure out when the video is a background autoplay video and treat it completely differently? |
More background video examples: Here is another case, although probably a separate issue: https://midcurrent.com/videos/how-to-tie-the-walts-worm/ (powered by https://www.mediaelementjs.com/) And another: https://gyazo.com/ |
We could avoid replacing background videos by updating the selector for Vimeo: --- a/src/data/socialwidgets.json
+++ b/src/data/socialwidgets.json
@@ -197,8 +197,8 @@
"Vimeo": {
"domain": "player.vimeo.com",
"buttonSelectors": [
- "iframe[src^='https://player.vimeo.com/video/']",
- "iframe[src^='//player.vimeo.com/video/']"
+ "iframe[src^='https://player.vimeo.com/video/']:not([src*='background=1'])",
+ "iframe[src^='//player.vimeo.com/video/']:not([src*='background=1'])"
],
"replacementButton": {
"details": "", The above tweak might be worth releasing just by itself as many background videos either have a fallback image that our replacement unhelpfully covers, or are part of the page layout in a way that our replacement widget makes worse. This could then be improved upon by detecting when we have one or more backgrounded Vimeo videos on the page and providing some sort of floating "activate Vimeo" in-page control. |
This should (mostly) be fixed in Privacy Badger version 2019.2.19. The Vimeo replacement now tries to ignore background videos, and since Vimeo is still on the yellowlist, background videos work unimpeded. However, we plan on removing Vimeo from the yellowlist in order to fix #188. Once we remove Vimeo, background Vimeo videos will get fully blocked and won't be shown anywhere. So this issue will become more relevant then again, and we will want to come up with a solution at some point, perhaps a special floating widget that works well with background videos. |
Found another instance of this happening in the latest version: https://brave.com/about/# |
What is your browser and browser version?
Firefox 65 / Chrome 72
What is broken and where?
When a site uses Vimeo as a background autoplay video, the new widget introduced in 2019.1.30 replaces the video and prevents the ability to play it all.
Some examples can be seen at:
What is the "culprit" domain?
player.vimeo.com is yellow and "replace social widgets" is enabled
What is your debug output for this domain?
The text was updated successfully, but these errors were encountered: