Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundcloud widgets are not reliably replaced #2331

Open
tjhietala opened this issue Mar 18, 2019 · 2 comments
Open

Soundcloud widgets are not reliably replaced #2331

tjhietala opened this issue Mar 18, 2019 · 2 comments
Labels
bug widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets

Comments

@tjhietala
Copy link

Soundcloud widget replacement does not seem to be working reliably.

Works here: https://soundcloud.com/pages/embed

Fails here (as an example): https://www.kvraudio.com/forum/viewtopic.php?f=14&t=521921&sid=e014f2dd651d6e75b9021d9265b2d7ef

Possibly related to #787

@ghostwords ghostwords added bug widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets labels Mar 18, 2019
@ghostwords
Copy link
Member

Hello! Thanks for the report.

Looks like this forum uses a custom loading solution for (SoundCloud) embeds. I think the page includes JavaScript that looks for SoundCloud links and appends the appropriate embed to each. The problem is that our replacement code runs before this replacement happens and doesn't run again so it misses the widget. (The replacement seems broken both when soundcloud.com is cookieblocked and when it is blocked.)

Basically our widget replacement doesn't yet work with custom embed loaders (#2262 (comment)).

@ghostwords
Copy link
Member

ghostwords commented Nov 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Development

No branches or pull requests

2 participants