Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Badger fails to unblock domains with DNT policy until after reload #2708

Closed
Hainish opened this issue Oct 30, 2020 · 6 comments
Closed
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy question Further information is requested

Comments

@Hainish
Copy link
Member

Hainish commented Oct 30, 2020

Related: EFForg/cover-your-tracks#49

When local learning is enabled, presence of the Do Not Track policy is not checked after a domain is initially added. In this example, no request is made to do-not-tracker.org:

pb

After reloading the page, Privacy Badger unblocks do-not-tracker.org and allows the request to proceed:

pb2

@ghostwords
Copy link
Member

Privacy Badger no longer checks DNT policies after first strike, rather only after fully learning to block the domain.

@ghostwords ghostwords added DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy question Further information is requested labels Oct 31, 2020
@ghostwords
Copy link
Member

ghostwords commented Oct 31, 2020

I wonder if we broke the DNT test with release 2020.5.12 that included the above PR.

Edit: We did.

@ghostwords
Copy link
Member

If that's the case, the solution then is to either add a DNT preload list to Privacy Badger, or to update Panopticlick to retry once for the DNT test. I greatly prefer and ask that Panopticlick simply retry the test for now.

@Hainish
Copy link
Member Author

Hainish commented Nov 2, 2020

I think it should be possible to ensure DNT is checked on the Panopticlick side before displaying the results.

@Hainish
Copy link
Member Author

Hainish commented Nov 6, 2020

Fixed in EFForg/cover-your-tracks@2b2c491

@Hainish Hainish closed this as completed Nov 6, 2020
@Hainish
Copy link
Member Author

Hainish commented Nov 6, 2020

This still seems to be an issue when JavaScript is disabled, where I don't see Privacy Badger blocking any trackers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants