Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Badger broken on Chrome Dev #901

Closed
ajthemacboy opened this issue Aug 28, 2016 · 9 comments
Closed

Privacy Badger broken on Chrome Dev #901

ajthemacboy opened this issue Aug 28, 2016 · 9 comments
Assignees

Comments

@ajthemacboy
Copy link

ajthemacboy commented Aug 28, 2016

Privacy Badger is reported as 'corrupt' on Chrome Dev (my exact version was 54.0.2837.0 dev-m (64 bit)) but works fine on the stable channel. I've tested on two different browsers. I have not tested the Beta or Canary channels. Clicking "Repair" reinstalls the extension with the same error.

This does not occur with any other extensions.

This occurs even when "Extension content verification" is set to Bootstrap in chrome://flags.

This issue also occurs with HTTPS Everywhere and has been reported on its GitHub as well.

@cowlicks
Copy link
Contributor

I can reproduce this.

@cowlicks
Copy link
Contributor

I suppose this could be the problem, from this chrome issue:

... downloading additional files to use in the extension that are placed in some new place should be fully supported. But self-modification of files that came in the original .crx cannot be.

@cowlicks
Copy link
Contributor

cowlicks commented Aug 29, 2016

I can't find a way to debug this so it's pretty opaque.

Privacy Badger does not use the filesystem api so I don't see how it could be changing its own files (which causes the issue in my last comment).

I don't think it is this zero length files bug because I couldn't find any zero length files.

https://bugs.chromium.org/p/chromium/issues/detail?id=399251#makechanges

@cowlicks
Copy link
Contributor

Maybe we are violating the default Content Security Policy we get by having "manifest_version": 2. I'm not even sure if this would cause the error we are seeing though. Basically we:

  • Can't use eval (but I don't think we do)
  • Can't use inline js (but I don't think we do)
  • Can only use local scripts, and object resources. (I think we do this)

But these rules don't apply to content scripts. Maybe I missed something.

@ajthemacboy
Copy link
Author

See EFForg/https-everywhere#5874

@josh-berry
Copy link

I am seeing this in Chrome Beta as well (53.0.2785.80 beta (64-bit)), on MacOS El Capitan (10.11.6), with Privacy Badger 2016.08.29.

Notably, I do NOT see the same issue with HTTPS Everywhere.

@cooperq
Copy link
Contributor

cooperq commented Aug 31, 2016

We have a fix for this now which will be in the next release. For now
you can go to chrome://flags and find the setting for 'extension content
verification' and change it from 'enforce strict' to 'enforce'. You then
can uninstall and reinstall the extension and it should be fixed. Once
the fix is released you should be able to change it back.
This is now fixed as of 731b76a

@cooperq cooperq closed this as completed Aug 31, 2016
@MikeN123
Copy link

MikeN123 commented Sep 3, 2016

Setting extension content verification to 'enforce' unfortunately doesn't fix the issue for me.

@cooperq
Copy link
Contributor

cooperq commented Sep 9, 2016

So it turns out this is an issue in chrome, the chrome devs are aware of it and are working on a fix now. Follow the issue here: https://bugs.chromium.org/p/chromium/issues/detail?id=643814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants