Pale Moon add-on bar support

[BoFiS]

So Pale Moon uses the same extension as FireFox, but as of 1.0.0 the icon does not appear in the add-on bar, though it used to. Now it just blocks things without giving me the ability to unblock or see that.

[LimboSlam]

I think some patches from AlexVallat (a member of the Ublock Team with good experience in the Firefox code) work may be the solution here? Also look at #447. Now I'm not a dev or very good in coding/programing so my info may be wrong.

Link: gorhill/uBlock#264 and gorhill/uMatrix#224 or to exact can be found here: gorhill/uBlock@master...AlexVallat:gorhil-master

NOTE: once there's a workable icon to go on, next it'll need to be tested with our beta version of Pale Moon (Pale Moon v26.0.0pb1 and pb2 of the Goanna engine) as there may be some compatibility issues with extensions that use the "code paths based on platform versions." But this should be a minimal impact because we are planing on returning a "compatibility version for historical reasons" to make sure these extensions remain compatible with us.

[LimboSlam]

Alright, I found PB v2.6.1 on one of my other profiles, so I have been testing it out on Pale Moon v26.0.0pb1 portable and everything seems to be working ok, meaning it installed (had to disable automatic updates/checking and with compatibility checks disable in about:config), shows icon and all functions work as if it was on a normal/stable version of Firefox (v24.8.1 ESR and of course current versions too) and Pale Moon (v25.6.0). Now all we need is a fix for the current version of PB and then go on from there.

[VeronicaGarcia]

Hi there, I'm fairly new to GitHub.

So, has there been any improvements on this, @BoFiS, @LimboSlam, @Nindaleth, @cooperq and @SwartzCr ?? I see bug #595 open too and it seems only @LimboSlam is the one who has actually look into this and gave valuable info on how to address this issue, an I correct or wrong?

I'm just asking because I feel like this issue has been ignored and that no solid feedback from the devs has been given, really.

[cooperq]

If someone wants to work on this and submit a patch I would happily accept it. As it currently stands I don't feel like I can prioritize this issue to work on personally.

[LimboSlam]

@cooperq and @VeronicaGarcia: yes I have gave some info that I think might help, but is right info, I don't know. I also want to mention that I'm not dev (not good anyways), so please don't think I will be doing any patching of the sort, only as mention up above have I given the info that might fix this issue.

Though if you look at #595, @cypherpunk seems to have some workable.

[BoFiS]

There has been no improvements to this issue, I had to stop using Privacy Badger as a result of not being able to control it in any way.