color wheel does not update to brightness

[nissaba]

The color wheel does not update its colors when the brightness slider is moved.

[EyreFree]

The brightness slider works well in demo project, can you provide more details?

[nissaba]

if you move the brightness slider the color picker is not updated, only the current color is.

in the 3 images the color selection disk/circle is alway the same.
normaly in other tools this would update to become fully black if the brightness slider is set to 0
and as the brightness increases the colors in the picker disk would get brighter as it goes up the scale.

as can bee seen in the following images example from XCode color picker.

[nissaba]

Sorry for the UGE image size.

[nissaba]

Hi. I finally noticed that in HSB the brightness bar changes as you move the small selector disk. and this is where you know the outcome of the color with adjust brightness will be. The Slider bar is ever so thin it is hard to see and I did not noticed until today that it was chaging as I was moving the selector in the color wheel.

So 1 suggestion is to make that bar thiker, so people that are presbyopic (like me) can notice the change. I did ask my graphic desinger to play with it, he also did not notieced that the sliderbar was chainging color and he as good eyesight.

An other solution is to keep the slider bar on a black to withe gradiant and have the colorwheel update its colormap base on the brightness.

I have updated my fork, as you change the brightness the color map updates.

[EyreFree]

Thanks for your contributions. Your PR has been merged.

You are the first user I know to actually use this library. Are you interested in being a collaborator of this project? In this way, you will be more convenient for the modification and development of this project.

I sent you a invitation, click the link to see: https://github.com/EyreFree/EFColorPicker/invitations.

😀

[nissaba]

Thanks. I have accepted it.