Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile in Xcode 12 as Swift Package Manager dependency #95

Closed
2 tasks done
skjiisa opened this issue Sep 17, 2020 · 2 comments · Fixed by #96
Closed
2 tasks done

Cannot compile in Xcode 12 as Swift Package Manager dependency #95

skjiisa opened this issue Sep 17, 2020 · 2 comments · Fixed by #96
Labels

Comments

@skjiisa
Copy link
Contributor

skjiisa commented Sep 17, 2020

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

  • I have read the README.md, but there is no information I need.
  • I have searched in existing issues, but did find a same one.

Issue Description

Description

If this package is added as a dependency to a project in Xcode 12, you get the warning:

The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

and the error:

The package product 'swift_qrcodejs' requires minimum platform version 9.0 for the iOS platform, but this target supports 8.0

This latter one looks like an issue with swift_qrcodejs, but adding just that to a project doesn't cause any warning or errors, so it appears to be an issue with EFQRCode.

Reproduce

Adding this through Xcode 12's "Add Package Dependency..." button to any project will create the errors specified above and the project will not compile.

Adding just swift_qrcodejs as a dependency to a project does not cause any issues.

@ApolloZhu
Copy link
Member

@isvvc could you please verify that spm-xc12 branch fixes this issue?

@ApolloZhu ApolloZhu added the bug label Sep 17, 2020
@skjiisa
Copy link
Contributor Author

skjiisa commented Sep 17, 2020

Yes, that did work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants