Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filtered searches #83

Closed
2 tasks done
mikesname opened this issue Feb 11, 2014 · 14 comments
Closed
2 tasks done

Date filtered searches #83

mikesname opened this issue Feb 11, 2014 · 14 comments

Comments

@mikesname
Copy link
Contributor

  • Make it an in string parameter instead of a facet
  • Make it a facet (Optional)

Need to allow filtering search by date period for doc units and authorities. This requires some changes to the index helper to output the Solr doc data for date periods.

Then we need to find the best way to query by date range.

@mikesname mikesname added this to the Phase 1 milestone Feb 11, 2014
@mikesname mikesname self-assigned this Feb 11, 2014
@mikesname
Copy link
Contributor Author

Implemented (in e8f2ca5) a facet extractor which converts the param of the form dates=1900-1940 into the appropriate query facet and applies it automatically. The param value must be of the form YEAR-YEAR, but either start and end year can be omitted, so that -1940 means "before 1940" and 1940- means "after 1940". All we need now is a UI to be able to send the parameter in that form.

@mikesname
Copy link
Contributor Author

@PonteIneptique do you fancy having a look at the UI for this now?

@PonteIneptique
Copy link
Contributor

Mind if I postpone it a little ? Like tomorrow ?

@mikesname
Copy link
Contributor Author

Heh, of course! I meant "now" as in "from this point on" ;)

@PonteIneptique
Copy link
Contributor

Duplicate of #128

@mikesname
Copy link
Contributor Author

Re-opening. This is a separate issue from the admin date entry.

@mikesname mikesname reopened this Feb 28, 2014
@PonteIneptique
Copy link
Contributor

Oh. I thought it was both for Portal...

@mikesname
Copy link
Contributor Author

I added a new admin tag 👍

@PonteIneptique PonteIneptique modified the milestone: Phase 1 Feb 28, 2014
@PonteIneptique
Copy link
Contributor

Hmm, the list of facet is controller generated. Where can I find utils.search.ItemPage[(DocumentaryUnit,utils.search.SearchHit)] and add the date ?

@PonteIneptique
Copy link
Contributor

I tried to add it myself but I come to have much more difficulties than expected.
Could you configure the controller/view so I have dates filter input enabled by default, even if there is no val ?

@mikesname mikesname modified the milestones: Phase 2, Phase 1 Mar 3, 2014
@mikesname
Copy link
Contributor Author

Not quite sure I understand this. Lets talk about it to confirm we're thinking about the same thing.

@PonteIneptique PonteIneptique modified the milestone: Phase 2 Mar 10, 2014
@retosp retosp modified the milestones: Phase 3, Phase 2 Mar 31, 2014
@PonteIneptique
Copy link
Contributor

Maybe it is time to get this thing working :)

@PonteIneptique
Copy link
Contributor

Make it an in string parameter instead of a facet

@PonteIneptique
Copy link
Contributor

@8befb71 resolve this issue. Need to check whether the actual UI pleases or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants