Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support adding no subtitles #12

Merged
merged 2 commits into from Dec 31, 2022
Merged

Conversation

EKarton
Copy link
Owner

@EKarton EKarton commented Dec 31, 2022

Description:

This PR contains multiple changes:

  1. Adding no subtitles to the generated PDF
  2. Creating integ tests for the main.py file
  3. Refactoring the test code

Usage of (1)

To add no subtitles to the generated PDF, one would need to supply the -S or --skip-subtitles flag to the cli tool, like:

python3 -m src.main tests/videos/input_1.mp4 -S -o output.pdf   

Running the command above will output a pdf with no subtitles, like:

output.pdf

@EKarton EKarton merged commit 4850f2b into main Dec 31, 2022
@EKarton EKarton deleted the feat/support-no-subtitles branch December 31, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant