feat: added srt support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is about adding .srt support for subtitles. This PR should not affect existing behaviour in parsing .webvtt subtitles.
If the subtitle filename ends in
.srt, it will use the SRT subtitle parser. Else, it will use the WebVTT subtitle parser.Manual Test:
pip3 install -r requirements.txtpython3 src/main.py tests/videos/input_1.mp4 -s tests/subtitles/subtitles_1.srt -o output.pdf. It outputted the subtitles correctly:output.pdf
python3 src/main.py tests/videos/input_2.mp4 -s tests/subtitles/subtitles_2.srt -o output.pdf. It outputted the subtitles correctly too:output.pdf
cd test && python3 -m unittest *and they all passed.