Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderEditor error handling #2

Open
Csabix opened this issue Aug 22, 2019 · 0 comments
Open

ShaderEditor error handling #2

Csabix opened this issue Aug 22, 2019 · 0 comments

Comments

@Csabix
Copy link
Member

Csabix commented Aug 22, 2019

Shader compilation errors are parsed and the line numbers are extracted using std::regex. Sometimes the template doesn't match the error, that needs investigation.

On AMD the errors look the same; however, the line numbers count from the beginning of the source code of the last file. On Nvidia and Intel the error line numbers are relative to the very first file, so I implemented a workaround. Thus, in case we have AMD hardware, we have to detect and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant