Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ecsconfig ping -cx loop when dtquery fails #317

Closed
padthaitofuhot opened this issue Jul 21, 2017 · 1 comment
Closed

Make ecsconfig ping -cx loop when dtquery fails #317

padthaitofuhot opened this issue Jul 21, 2017 · 1 comment
Assignees
@padthaitofuhot
Labels
bug Minor
Milestone
Install Node 2.5.0

Comments

@padthaitofuhot
Copy link
Contributor

The current (bugged) behavior is to exit the loop when we get PONG from endpoint no matter the status of dtquery. However, this breaks flow control that depends on the -cx behavior exiting only when the ECS bootstrap health appears good.
@padthaitofuhot padthaitofuhot added this to the Install Node 2.4.0 milestone Jul 21, 2017
@padthaitofuhot padthaitofuhot self-assigned this Jul 21, 2017
@padthaitofuhot padthaitofuhot changed the title Make ecsconfig ping -cx loop when dtquery Make ecsconfig ping -cx loop when dtquery fails Jul 21, 2017
@padthaitofuhot padthaitofuhot added this to Current Patch (2.3.1) in Installer 2.x Jul 26, 2017
@padthaitofuhot padthaitofuhot moved this from Current Patch (2.3.1) to Milestone 2.4.0 To-Do in Installer 2.x Jul 26, 2017
@padthaitofuhot padthaitofuhot moved this from Milestone 2.4.0 To-Do to Milestone 2.5.0 To-Do in Installer 2.x Aug 22, 2017
@padthaitofuhot padthaitofuhot moved this from Milestone 2.5.0 To-Do to Current Milestone In-Progress in Installer 2.x Aug 29, 2017
@padthaitofuhot
Copy link
Contributor Author

Resolved by #344

@padthaitofuhot padthaitofuhot moved this from Current Milestone In-Progress to Needs Review in Installer 2.x Aug 31, 2017
@padthaitofuhot padthaitofuhot moved this from Needs Review to Done in Installer 2.x Aug 31, 2017
@padthaitofuhot padthaitofuhot removed this from Done in Installer 2.x Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padthaitofuhot padthaitofuhot

Labels
bug Minor
Projects
None yet
Milestone
Install Node 2.5.0
Development

No branches or pull requests
1 participant
@padthaitofuhot