Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable svelte-check? #160

Closed
NfNitLoop opened this issue Jan 6, 2023 · 2 comments
Closed

Option to enable svelte-check? #160

NfNitLoop opened this issue Jan 6, 2023 · 2 comments
Labels
enhancement New feature or request stale Issues that can probably be closed (esbuild-svelte isn't to blame for the problem)

Comments

@NfNitLoop
Copy link

NfNitLoop commented Jan 6, 2023

I just realized that esbuild-svelte doesn't do type checks, because svelte preprocessor doesn't do type checks.

I'd love to (optionally) include type checks in my esbuild run because they can save me a lot of runtime headaches.

It would be nice if this were an option in esbuild-svelte so I don't have to roll my own.

I suppose as a workaround I can hack it into my package.json scripts to just run before kicking off esbuild.

@NfNitLoop NfNitLoop added the enhancement New feature or request label Jan 6, 2023
@EMH333
Copy link
Owner

EMH333 commented Jan 7, 2023

Unfortunately I think the "hack" of adding svelte-check or something similar into your npm scripts is probably the best bet here.

esbuild doesn't do type checks either, which means there isn't really a clean way for esbuild-svelte to incorporate type checks into it's run without adding additional complexity and extraneous dependencies for non-typescript users.

Open to suggestions on this, but I see type checks as the responsibility of an external program (like svelte-check) or a preprocessor.

@EMH333 EMH333 added the stale Issues that can probably be closed (esbuild-svelte isn't to blame for the problem) label Mar 22, 2023
@EMH333
Copy link
Owner

EMH333 commented Jul 18, 2023

Closing this as out of scope

@EMH333 EMH333 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that can probably be closed (esbuild-svelte isn't to blame for the problem)
Projects
None yet
Development

No branches or pull requests

2 participants