Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating examples to use the 0.17.x esbuild "context API"? #180

Closed
silverdr opened this issue May 28, 2023 · 3 comments
Closed

Updating examples to use the 0.17.x esbuild "context API"? #180

silverdr opened this issue May 28, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@silverdr
Copy link

Is your feature request related to a problem? Please describe.
Updating esbuild to any of the 0.17 versions breaks "watch mode". This is described in the esbuild documentation that the option was simply removed for ... reasons

Describe the solution you'd like
I would like to be able to properly use "watch" mode again after updating esbuild to 0.17.x or later. It probably doesn't require any changes to esbuild-svelte (I guess ?) but rather to example buildscript.js files

@silverdr silverdr added the enhancement New feature or request label May 28, 2023
@EMH333 EMH333 added documentation Improvements or additions to documentation good first issue Good for newcomers and removed enhancement New feature or request labels May 28, 2023
@EMH333
Copy link
Owner

EMH333 commented May 28, 2023

Yes I should probably update that example. The reason I've been holding off is because esbuild 0.17.x breaks the auto-magical caching logic that esbuild-svelte uses. I'm still holding out hope for evanw/esbuild#2823 to be acted upon so that can continue.

I'll see if I have some time soon to get this plugin updated w/ 0.17 examples.

@silverdr
Copy link
Author

That would be totally awesome ;-)

@EMH333
Copy link
Owner

EMH333 commented Sep 5, 2023

esbuild-svelte now supports the context API internally (as of v0.8.0) and enough time has passed that there are examples online of how to use the context API for building projects. If you are having specific trouble, feel free to open a discussion, and we can work from there.

@EMH333 EMH333 closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants