Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example in request-params.Rmd #160

Open
maelle opened this issue Feb 28, 2024 · 4 comments
Open

update example in request-params.Rmd #160

maelle opened this issue Feb 28, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@maelle
Copy link
Collaborator

maelle commented Feb 28, 2024

We have this example code in a pkgdown article

library(EMODnetWFS)

wfs <- emodnet_init_wfs_client("human_activities")

emodnet_get_layers(
  wfs = wfs,
  layers = "maritimebnds",
  featureID = "maritimebnds.861",
  reduce_layers = TRUE
)

However "martimebnds" seems to no longer be a layer for this service.

@salvafern I have two questions

  • is that "maritimebnds" boundary in another service? Did it just disappear? How would user know about changes in available layers?
  • do you know of another example we could use instead in the article. It needs to be a layer with featureIDs (not sure where to find those), a feature we can use to sortBy, enough features for startIndex to be interesting, propertyName to be useful, and it needs geometry to demonstrate filtering by a box. Also how can we choose one that doesn't disappear?

https://github.com/EMODnet/EMODnetWFS/blob/main/vignettes/articles/request-params.Rmd

@maelle maelle added the documentation Improvements or additions to documentation label Feb 28, 2024
@salvafern
Copy link
Collaborator

This layer was temporaly removed from EMODnet due to lifewatch/marineregions-issues#13 - we will update the maritime boundaries product in the next release.

I would say better to not use layers from Human Activities as anything with a political content is more prone to change / disappear. In general layers should not be taken down but I wouldn't be surprised if it happens again without notification. Not sure I have a solution.

I will look for a layer that works as an example

@maelle
Copy link
Collaborator Author

maelle commented Mar 5, 2024

Thank you! I'll wait for an update from you then. 🙏

@maelle
Copy link
Collaborator Author

maelle commented Mar 21, 2024

@salvafern Friendly reminder 😸

@maelle maelle added this to the rOpenSci submission milestone Mar 28, 2024
@maelle
Copy link
Collaborator Author

maelle commented May 10, 2024

@salvafern any update? 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants