Bug human_activities + majorcatches

[maelle]

library("EMODnetWFS")
wfs <- emodnet_init_wfs_client(service = "human_activities")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> Loading IANA mime types...
#> No encoding supplied: defaulting to UTF-8.
#> ✓ WFS client created succesfully
#> ℹ Service: 'https://ows.emodnet-humanactivities.eu/wfs'
#> ℹ Version: '2.0.0'

   or_filter_sf <- emodnet_get_layers(
        wfs = wfs,
        layers = "majorcatches",
        cql_filter = "country='Baltic Sea' OR country='Bulgaria'",
        reduce_layers = TRUE
    )
#> Warning: Download of layer 'majorcatches' failed: Error: Cannot open "/tmp/RtmpZxxHz3/file630649c69027.gml"; The source could be corrupt or not supported. See `st_drivers()` for a list of supported formats.

^{Created on 2022-03-02 by the reprex package (v2.0.1)}

[maelle]

library("EMODnetWFS")
wfs <- emodnet_init_wfs_client(service = "bathymetry")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> Loading IANA mime types...
#> No encoding supplied: defaulting to UTF-8.
#> ✓ WFS client created succesfully
#> ℹ Service: 'https://ows.emodnet-bathymetry.eu/wfs'
#> ℹ Version: '2.0.0'

simple_filter_sf <- emodnet_get_layers(
    wfs = wfs,
    layers = "contours",
    cql_filter = "country='Baltic Sea'",
    reduce_layers = TRUE
)
#> Warning: Download of layer 'contours' failed: Error: Cannot open "/tmp/RtmpjsPInd/file866b45f8156c.gml"; The source could be corrupt or not supported. See `st_drivers()` for a list of supported formats.

^{Created on 2022-03-02 by the reprex package (v2.0.1)}

[maelle]

@annakrystalli Could you try to run the two reprexes above and see whether they fail for you too?

[annakrystalli]

That's because the country attribute doesn't exist in those layers:

library("EMODnetWFS")
wfs <- emodnet_init_wfs_client(service = "human_activities")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> Loading IANA mime types...
#> No encoding supplied: defaulting to UTF-8.
#> ✓ WFS client created succesfully
#> ℹ Service: 'https://ows.emodnet-humanactivities.eu/wfs'
#> ℹ Version: '2.0.0'


   or_filter_sf <- emodnet_get_layers(
        wfs = wfs,
        layers = "majorcatches",
        cql_filter = "country='Baltic Sea' OR country='Bulgaria'",
        reduce_layers = TRUE
    )
#> Warning: Download of layer 'majorcatches' failed: Error: Cannot open "/private/var/folders/8p/87cqdx2s34vfvcgh04l6z72w0000gn/T/RtmpGQ0igj/filede191b171af0.gml"; The source could be corrupt or not supported. See `st_drivers()` for a list of supported formats.

   


any("country" %in% layer_attributes_get_names(wfs, layer = "majorcatches"))
#> [1] FALSE
any("country" %in% layer_attributes_get_names(service = "bathymetry", layer = "contours"))
#> ✓ WFS client created succesfully
#> ℹ Service: 'https://ows.emodnet-bathymetry.eu/wfs'
#> ℹ Version: '2.0.0'
#> [1] FALSE

^{Created on 2022-03-02 by the reprex package (v2.0.1)}

[annakrystalli]

The handling of these filtering messages definitely need improving

[maelle]

Ok then this should be tackled by #54 :-)