Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of requests.get is broken. #1

Open
proofit404 opened this issue Dec 1, 2018 · 3 comments
Open

Signature of requests.get is broken. #1

proofit404 opened this issue Dec 1, 2018 · 3 comments

Comments

@proofit404
Copy link

We can't use

requests.get("http://api.linkpreview.net/", {"key": key, "q": url})

anymore.

@rbas
Copy link
Contributor

rbas commented Dec 3, 2018

Hi @proofit404 ,
could you explain it more, please? What it means that it is broken? What it doing?

@proofit404
Copy link
Author

https://github.com/requests/requests/blob/b0ad2499c8641d29affc90f565e6628d333d2a96/requests/api.py#L63

The issue is that you can't use params as a positional argument after your monkey patches.

So code which works with requests doesn't work with your toolbar extension.

@rbas
Copy link
Contributor

rbas commented Dec 3, 2018

Oh you're right. I'll fix it.
Thank you for report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants