Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Content" and "Stack trace" links do not work #2

Open
yigor opened this issue Feb 5, 2019 · 5 comments
Open

"Content" and "Stack trace" links do not work #2

yigor opened this issue Feb 5, 2019 · 5 comments

Comments

@yigor
Copy link

yigor commented Feb 5, 2019

Hello,

I've tried your plugin, everything seems to be working, except those "Content" and "Stack trace" don't actually do anything. Was there supposed to be some JavaScript that would handle clicks on .requests-toolbar-open links in order to show hidden table rows?

Thanks,
Igor

@rbas
Copy link
Contributor

rbas commented Feb 6, 2019

Hi,
yes there is Javascript (https://github.com/ENERGYLINX/django-debug-toolbar-requests/blob/master/requests_toolbar/templates/requests_toolbar/panels/requests.html#L67) could you look at into browser's console? Maybe there is the bug.

@yigor
Copy link
Author

yigor commented Feb 6, 2019

Ah, now I see what's going on. You are using jQuery but django-debug-toolbar removed jQuery dependency in 1.10. So your code doesn't work because djdt.jQuery is undefined. Downgrading django-debug-toolbar to 1.9.1 kind of did the trick.

@rbas
Copy link
Contributor

rbas commented Feb 6, 2019

Ah, I didn't noticed... I'm still using the old one.
Could you fix it, please?

@yigor
Copy link
Author

yigor commented Feb 6, 2019

Fixed in #3

@rbas
Copy link
Contributor

rbas commented Feb 7, 2019

Great, I'll check and release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants