Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix codecov upload in forked PRs #58

Closed
o-laurent opened this issue Oct 24, 2023 · 3 comments
Closed

🔧 Fix codecov upload in forked PRs #58

o-laurent opened this issue Oct 24, 2023 · 3 comments
Labels
bug Something isn't working CI/CD About GitHub workflows

Comments

@o-laurent
Copy link
Contributor

The token is not valid, and we cannot upload the coverage cf. this GitHub action.
@o-laurent o-laurent added bug Something isn't working CI/CD About GitHub workflows labels Oct 24, 2023
@o-laurent
Copy link
Contributor Author

o-laurent commented Oct 24, 2023 •
edited

As Quentin's branch is also called main, it modified the coverage of origin/main branch. Linked to codecov/engineering-team#661.

@o-laurent o-laurent mentioned this issue Oct 25, 2023
Closed
@qbouniot
Copy link
Collaborator

Unfortunately, changing the branch name from which the PR comes from did not update the coverage of origin/main branch ...

@o-laurent
Copy link
Contributor Author

Unfortunately, changing the branch name from which the PR comes from did not update the coverage of origin/main branch ...

We have to push on main to change it, but pushing on your PR won't change the cov. again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI/CD About GitHub workflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qbouniot @o-laurent