nodeos Non-Zero Exit Status for Expected Behavior

[kj4ezj]

When running nodeos --version or nodeos --help, the process exits with a non-zero exit status (-1 in C++, 255 in BASH). Conventionally, this means the program has encountered an error. This will cause shell environments or scripts with -e set to exit with a failure.

This is happening because main() calls app:initialize() which prints the requested information. It returns false because nodeos was not initialized, but main() takes this as an initialization failure.

Looking at this with arhag, we also believe the FIXED_REVERSIBLE and EXTRACTED_GENESIS cases should return EXIT_SUCCESS.

Steps to Reproduce the Issue

In BASH:

$ nodeos --version
v1.7.0-rc2-57-gc0b542edc
$ echo $?
255
$ nodeos --help
$ echo $?
255

Note that all supported versions of nodeos are effected at the time this issue was created.

Recommended Solution

Return EXIT_SUCCESS in these four cases, which is equal to zero.

[andriantolie]

PR merged