Odd Name serialization

[jafri]

Eosjs name serialization is a little odd with capitalized names

For example it will serialize Sncqu.wam into ncqu.wam, could we perhaps have it make names lowercase automatically?

[jlamarr22]

Thanks for logging this issue. I agree that there's a lot of hidden logic in serialization that is supposed to help people use it. If data is in the correct format that the chain expects, then it seems like everything serializes properly, but I can see how this would be confusing when input != output.

I'm thinking throwing an error for invalid characters during serialization would make more sense than modifying the input, because that helps the dev understand the underlying logic and format properly on subsequent requests. What do you think?

[jafri]

@jlamarr22 throwing an error to the line of "name must be lowercase" would be fine

[jafri]

@jlamarr22 can we have a fix come in soon, theres people losing funds on different wallets across EOSIO daily

[jlamarr22]

@jafri Apologies for the delay. We're working on a fix for this, so should have it to you in within the next couple days.

[bradlhart]

@jafri eosjs@21.0.0-8deba86.0 contains the changes from #726 and should resolve the issue. It will also likely be included in a patch version after eosjs@v21 is stable.