Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer card displays loading... when an empty directory is selected in fileOpenDialog #591

Closed
nelsonni opened this issue Jan 3, 2022 · 0 comments · Fixed by #806 or #807
Closed

Explorer card displays loading... when an empty directory is selected in fileOpenDialog #591

nelsonni opened this issue Jan 3, 2022 · 0 comments · Fixed by #806 or #807
Assignees
@nelsonni
Labels
bug Bug reports or bug fixes

Comments

@nelsonni
Copy link
Member

nelsonni commented Jan 3, 2022 •
edited

Describe the bug
Selecting any empty directory within the fileOpenDialog will result in an Explorer card instance that permanently holds the loading... state. This state was meant to provide a graceful default state while the directory content is loading, but in this case there will always be 0 sub-files and sub-directories.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Synectic
  2. Go to File → Open...
  3. Select any empty directory
  4. Click the Open button
  5. Wait for Explorer card to load
  6. See error

Expected behavior
An icon and/or text indicating that the selected directory is empty.

Screenshots
Screen Shot 2022-01-02 at 6 30 59 PM

Versions (please complete the following information):

  • OS: MacOS, Windows, Linux
  • Synectic Version: 1.0.0-beta (branch: development)

Additional context
Relevant code that checks and displaying the loading... state is available in Explorer.tsx:54-55.
@nelsonni nelsonni added the bug Bug reports or bug fixes label Jan 3, 2022
@nelsonni nelsonni self-assigned this Jun 7, 2022
@nelsonni nelsonni linked a pull request Jun 7, 2022 that will close this issue
Use TS 4.7 Instantiation Expressions for filterObject return type #806
Merged
5 tasks
@nelsonni nelsonni removed a link to a pull request Jun 7, 2022
Use TS 4.7 Instantiation Expressions for filterObject return type #806
Merged
5 tasks
@nelsonni nelsonni linked a pull request Jun 7, 2022 that will close this issue
Use TS 4.7 Instantiation Expressions for filterObject return type #806
Merged
5 tasks
@nelsonni nelsonni mentioned this issue Jun 7, 2022
Merged
@nelsonni nelsonni changed the title Explorer card displays 'loading...' when an empty directory is selected in fileOpenDialog Explorer card displays loading... when an empty directory is selected in fileOpenDialog Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonni nelsonni

Labels
bug Bug reports or bug fixes
Projects
None yet
Milestone
No milestone
1 participant
@nelsonni