Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition FSCache to use createListenerMiddleware() from @reduxjs/toolkit #676

Closed
nelsonni opened this issue Mar 8, 2022 · 0 comments · Fixed by #691 or #807
Closed

Transition FSCache to use createListenerMiddleware() from @reduxjs/toolkit #676

nelsonni opened this issue Mar 8, 2022 · 0 comments · Fixed by #691 or #807
Assignees
Labels
feature Feature requests or improvements

Comments

@nelsonni
Copy link
Member

nelsonni commented Mar 8, 2022

Is your feature request related to a problem? Please describe.
The current FSCache relies on cache Redux Middleware in order to intercept and react to dispatching actions before they reach the reducers. However, with v1.8.0 of @reduxjs/toolkit there is a new alternative in the form of createListenerMiddleware.

Describe the solution you'd like
Replace the custom-built cache Redux Middleware with the new createListenerMiddleware.

Describe alternatives you've considered
Keeping the custom middleware in place for the foreseeable future is an alternative, but eventually there is likely to be very useful updates to createListenerMiddleware and taking advantage of those would still require making this transition.

Additional context
There are several issues that tracked the development of this new API, including:

@nelsonni nelsonni added the feature Feature requests or improvements label Mar 8, 2022
@nelsonni nelsonni self-assigned this Mar 8, 2022
@nelsonni nelsonni mentioned this issue Jun 7, 2022
@nelsonni nelsonni linked a pull request Jun 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests or improvements
Projects
None yet
1 participant