Set background image for canvas. #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmarzeion
requested changes
Jul 3, 2020
| @@ -143,14 +148,30 @@ class _PathHistory { | |||
| _inDrag = false; | |||
| } | |||
|
|
|||
| void draw(Canvas canvas, Size size) { | |||
| void draw(Canvas canvas, Size size, Image image) { | |||
There was a problem hiding this comment.
I am a bit concerned about potential performance issues of this approach.
Because we cache path data (so its possible to undo), performance is worse with every new stroke.
That issue should be fixed some day, but it required much work due to advanced complexity.
Approach you introduced brings another weight to #draw method. I think that it would be much better if we just use flutter Stack widget to place background image under painting canvas.
|
Thanks for contribution! |
|
The requested changes where not implemented since 10 months now, so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a background image to canvas via controller
Example updated with FAB to set background image (if Background image set the background colour is not taken into account.)
I hope this helps setting background image