Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake configuration fails with versions >3.23.0 and <3.24.0 #1816

Closed
mapgccv opened this issue Jun 27, 2024 · 0 comments
Closed

CMake configuration fails with versions >3.23.0 and <3.24.0 #1816

mapgccv opened this issue Jun 27, 2024 · 0 comments

Comments

@mapgccv
Copy link
Contributor

mapgccv commented Jun 27, 2024

A condiotional policy setting in the CMake file makes builds fail with the above mentioned versions of CMake.
Policy CMP0138 was introduced in version 3.24.0 (https://cmake.org/cmake/help/latest/policy/CMP0138.html) but the policy is specified in:

    if(CMAKE_VERSION VERSION_GREATER  "3.23.0") 
      cmake_policy(SET CMP0138 NEW)
    endif()

making the build fail with CMake 3.23.3 (which is the default in manylinux 2010).
I will submit a pull request shortly with the simply fix.

Great work, by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant