Check version #71
Closed
Check version #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tony-go We need to update this PR with the new back-end. |
|
For sure! In the description, I was asking for a bit of feedback regarding this implementation. Do you have feedback to provide regarding this? :) Otherwise, It will my next challenge. |
|
@tony-go i think the implementation was ok. I will probably rename the variable in a future release too ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hi,
Following our discussion on issue #69, here a proposal on how we could handle the check of the version.
I'm not sure to follow the specification, so If it misses something, let me know. (For example, I throw an error if the versions miss in the package JSON, so it will throw for all packages generated before our previous commit 馃槅)
I open it as a draft at first, then if it's okay for you I'll implement this check version in the other commands.